RTEMS / Packages / Network Services¶
Go to Issues or Merge Requests
Issues¶
13 - Backport MR21 to 6 branch¶
Id |
13 |
State |
closed |
Type |
ISSUE |
Author |
Kinsey Moore |
Assignee(s) |
Kinsey Moore |
Closed by |
Kinsey Moore |
Created |
2025-03-06T20:26:40.170Z |
Closed |
2025-03-07T04:15:46.850Z |
Updated |
2025-03-07T04:15:46.863Z |
Milestone |
6.2 |
Labels |
pkg::network-services |
Link |
https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/issues/13 |
Merges |
0 |
The following discussion from !21 should be addressed:
[] @opticron started a discussion:
This needs to be backported to 6 branch.
Author: Kinsey Moore
2025-03-06T20:26:40.355Z
assigned to @opticron
Author: Kinsey Moore
2025-03-06T20:26:40.754Z
Author: Kinsey Moore
2025-03-06T20:32:14.024Z
mentioned in merge request !22
11 - Backport NTP bug fixes to 6 branch¶
Id |
11 |
State |
closed |
Type |
ISSUE |
Author |
Kinsey Moore |
Assignee(s) |
Kinsey Moore |
Closed by |
Kinsey Moore |
Created |
2025-02-25T15:56:42.985Z |
Closed |
2025-03-02T01:46:05.997Z |
Updated |
2025-03-02T01:46:06.032Z |
Milestone |
6.2 |
Labels |
network, pkg::network-services |
Link |
https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/issues/11 |
Merges |
0 |
The following discussion from !18 should be addressed:
[] @opticron started a discussion:
This needs to be backported to 6 branch as well.
Author: Kinsey Moore
2025-02-25T15:56:43.186Z
assigned to @opticron
Author: Kinsey Moore
2025-02-25T15:56:43.466Z
Author: Kinsey Moore
2025-02-25T16:04:00.728Z
mentioned in merge request !19
17 - Add ntpd sys var query and sync status calls (opened)¶
Id |
17 |
State |
opened |
Type |
ISSUE |
Author |
Chris Johns |
Assignee(s) |
Chris Johns |
Created |
2025-05-22T22:41:16.901Z |
Updated |
2025-05-23T01:03:22.756Z |
Milestone |
6.2 |
Labels |
pkg::ntp |
Link |
https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/issues/17 |
Merges |
0 |
Add ntpd sys var query and sync status calls to return the system level state of NTP. This call accesses the state directly and avoids the overhead or performing an ntpq query on the 127.0.0.1 address.
Provide calls to initialize the files for a client pool configuration. This is the most common RTEMS use case.
Author: Chris Johns
2025-05-22T22:41:17.003Z
assigned to @chris
Author: Chris Johns
2025-05-23T00:54:33.789Z
mentioned in merge request !29
Author: Kinsey Moore
2025-05-23T01:03:22.984Z
15 - ntp: Backport ieeefp.h fix for coldfire to 6 branch (opened)¶
Id |
15 |
State |
opened |
Type |
ISSUE |
Author |
Kinsey Moore |
Assignee(s) |
Kinsey Moore |
Created |
2025-03-19T17:22:04.634Z |
Updated |
2025-04-08T00:24:07.292Z |
Milestone |
6.2 |
Labels |
pkg::network-services |
Link |
https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/issues/15 |
Merges |
0 |
Summary¶
This issue exists in 6 and the fix needs to be backported.
Steps to reproduce¶
Pre-set options¶
Author: Kinsey Moore
2025-03-19T17:22:04.918Z
assigned to @opticron
Author: Kinsey Moore
2025-03-19T17:22:05.425Z
Author: Kinsey Moore
2025-03-19T17:24:18.529Z
mentioned in merge request !24
Author: Jeremy Lorelli
2025-04-08T00:24:07.242Z
mentioned in merge request !25
10 - NTP broadcast client fails to open sockets on lwIP (opened)¶
Id |
10 |
State |
opened |
Type |
ISSUE |
Author |
Kinsey Moore |
Assignee(s) |
Trac Migrate |
Created |
2023-10-04T19:42:57.000Z |
Updated |
2025-01-31T18:30:49.415Z |
Milestone |
6.2 |
Labels |
network::lwip, priority::normal, tickettype::defect, version::6 |
Link |
https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/issues/10 |
Merges |
0 |
Reproduction: * Install lwIP on top of a compatible BSP * Modify the existing ntp01 test to use the broadcast client * Set NTP_DEBUG to 1 * Replace the first two lines of etc_ntp_conf with: * broadcastclient * disable auth * Build rtems-net-services against the installed BSP with lwIP network stack * Run the modified ntp01 test
Expected result: NTP opens broadcast listener successfully.
Actual result: NTP fails to open broadcast listener with error message: bind(37) AF_INET 0.0.0.0#123 flags 0x409 failed: Address already in use
Workaround: In open_socket() in bsd/freebsd/contrib/ntp/ntpd/ntp_io.c, there is a test for wildcard addresses inside a OS_NEEDS_REUSEADDR_FOR_IFADDRBIND conditional. If the set_wildcard_reuse() call is made unconditional, the socket creation succeeds.
The root cause is that behavior differs between LibBSD and lwIP. On lwIP, early-bound wildcard and non-wildcard address bindings succeed, but late-bound wildcard address bindings fail. Once any any address is bound, lwIP will fail to bind any further wildcard sockets. Either we can change lwIP’s behavior to be closer to LibBSD or we can alter the NTP client to check for lwIP or blindly apply the address reuse flags.
Author: Kinsey Moore
2025-01-31T18:30:49.389Z
assigned to @tracmigrate
Author: Kinsey Moore
2023-10-04T19:44:27.000Z
Description changed
Reproduction: * Install lwIP on top of a compatible BSP * Modify the existing ntp01 test to use the broadcast client - ** Set NTP_DEBUG to 1 ? - + * Set NTP_DEBUG to 1 ? + - ** Replace the first two lines of etc_ntp_conf with: ? - + * Replace the first two lines of etc_ntp_conf with: ? + - *** broadcastclient ? -- + * broadcastclient ? ++ - *** disable auth ? -- + * disable auth ? ++ * Build rtems-net-services against the installed BSP with lwIP network stack * Run the modified ntp01 test Expected result: NTP opens broadcast listener successfully. Actual result: NTP fails to open broadcast listener with error message: bind(37) AF_INET 0.0.0.0#123 flags 0x409 failed: Address already in use Workaround: In open_socket() in bsd/freebsd/contrib/ntp/ntpd/ntp_io.c, there is a test for wildcard addresses inside a OS_NEEDS_REUSEADDR_FOR_IFADDRBIND conditional. If the set_wildcard_reuse() call is made unconditional, the socket creation succeeds. The root cause is that behavior differs between LibBSD and lwIP. On lwIP, early-bound wildcard and non-wildcard address bindings succeed, but late-bound wildcard address bindings fail. Once any any address is bound, lwIP will fail to bind any further wildcard sockets. Either we can change lwIP's behavior to be closer to LibBSD or we can alter the NTP client to check for lwIP or blindly apply the address reuse flags.
Author: Chris Johns
2023-10-04T21:30:43.000Z
I think NTP is using _normal_ behavior so lwIP is not compliant in this case. Adding a work around to NTP solves this problem but leaves the issue present other packages may trip over.
Have you asked lwIP about this?
Author: Kinsey Moore
2023-10-05T17:08:40.000Z
I haven’t. This was an issue I noticed and wanted to document that it existed with current thoughts, but I hadn’t moved beyond that yet since the broadcast client isn’t on my priority list at the moment. I’ll agree with you that fixing lwIP to be more “normal” is probably the right solution. I’ll get more context from lwIP.
Author: Gedare Bloom
2024-12-04T21:40:36.490Z
changed the description
Author: Gedare Bloom
2024-12-04T21:40:37.588Z
Author: Kinsey Moore
2025-01-31T18:30:49.674Z
moved from rtems/rtos/rtems#4958
Merge Requests¶
29 - bsd/ntpd: Add ntpd sys var query and sync status calls¶
Id |
29 |
State |
merged |
Merged by |
Kinsey Moore |
Merged at |
2025-05-23T01:03:36.311Z |
Assignee(s) |
Chris Johns |
Created |
2025-05-23T00:54:24.204Z |
Updated |
2025-05-23T01:03:38.282Z |
Milestone |
6.2 |
Labels |
pkg::network-services |
Link |
https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/29 |
Commit |
Add ntpd sys var query and sync status calls
Provide calls to get the NTP status without using ntpq. The data returned is the same.
Add a command
ntpsvto print the status without usingntpq.
Update #17
Author: Chris Johns
2025-05-23T00:54:24.438Z
assigned to @chris
Author: Kinsey Moore
2025-05-23T01:03:30.195Z
approved this merge request
27 - legacy: Add missing include¶
Id |
27 |
State |
merged |
Merged by |
Joel Sherrill |
Merged at |
2025-05-08T22:50:33.575Z |
Assignee(s) |
Kinsey Moore |
Created |
2025-05-08T12:53:22.099Z |
Updated |
2025-05-08T23:31:34.608Z |
Milestone |
6.2 |
Labels |
network::legacy |
Link |
https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/27 |
Commit |
Summary¶
legacy: Add missing include
GCC was warning about implicit declaration of strcmp
Author: Kinsey Moore
2025-05-08T12:53:22.350Z
assigned to @opticron
Author: Joel Sherrill
2025-05-08T22:50:28.430Z
approved this merge request
24 - ntp: Avoid including broken (on Coldfire) ieeefp.h header¶
Id |
24 |
State |
merged |
Merged by |
Joel Sherrill |
Merged at |
2025-05-08T23:08:09.528Z |
Assignee(s) |
Kinsey Moore |
Created |
2025-03-19T17:24:00.778Z |
Updated |
2025-05-08T23:08:11.969Z |
Milestone |
6.2 |
Link |
https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/24 |
Commit |
Summary¶
ntp: Avoid including broken (on Coldfire) ieeefp.h header
The LDBL_EQ_DBL define in newlib.h is determined at GCC/newlib configure time and is shared between all 68k targets. The default 68k target for GCC supports long double (12 bytes), while the Coldfire ISA does not. This results in LDBL_EQ_DBL being undefined for Coldfire targets, even though double and long double are indeed equal. ieeefp.h has sanity checks that fail if LDBL_EQ_DBL is not defined when sizeof(long double) == sizeof(double).
A workaround is to avoid including this header. In this case, it doesn’t seem to be a necessary include anyway.
Closes #15
Author: Kinsey Moore
2025-03-19T17:24:01.177Z
assigned to @opticron
Author: Gedare Bloom
2025-05-08T23:06:23.395Z
This disables it for all targets. I’d like to get input from @chris
Author: Chris Johns
2025-05-08T23:06:23.395Z
I think we should to aim to have 3rd party code operate as close as possible to upstream. @jjl77 can the guard please be made conditional on
m68k?
Author: Jeremy Lorelli
2025-05-08T23:06:23.395Z
I’ve made the guard include __m68k__ in !25. Not sure if you also want me to apply an additional change to main, since !23 was merged there with this change.
Author: Kinsey Moore
2025-05-08T23:06:23.395Z
I have pulled that patch into this MR.
Author: Jeremy Lorelli
2025-04-08T00:24:07.391Z
mentioned in merge request !25
Author: Kinsey Moore
2025-05-08T12:59:05.252Z
added 1 commit
784f2a43 - ntp: Avoid including broken (on Coldfire) ieeefp.h header
Author: Joel Sherrill
2025-05-08T23:06:23.412Z
resolved all threads
Author: Joel Sherrill
2025-05-08T23:07:34.710Z
approved this merge request
Author: Joel Sherrill
2025-05-08T23:07:47.259Z
added 2 commits
6214c7e2 - 1 commit from branch
rtems/pkg:613f7dc2b - ntp: Avoid including broken (on Coldfire) ieeefp.h header
22 - 6/ntp: Fix a hang with sleeping workers and bad behavior with reverse time jumps¶
Id |
22 |
State |
merged |
Merged by |
Chris Johns |
Merged at |
2025-03-07T00:28:11.062Z |
Assignee(s) |
Kinsey Moore |
Created |
2025-03-06T20:32:04.428Z |
Updated |
2025-03-07T00:28:12.362Z |
Milestone |
6.2 |
Labels |
pkg::network-services |
Link |
https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/22 |
Commit |
Summary¶
This fixes a pair of issues with NTP, one causing a hang and one causing the NTP client to ignore the server until the previous time rolls back over.
Updates #13
Author: Kinsey Moore
2025-03-06T20:32:04.742Z
assigned to @opticron
Author: Kinsey Moore
2025-03-06T20:32:53.742Z
changed title from ntp: {-Ensure workers eventually process all request-}s to {+6/+}ntp: {+Fix a hang with sleeping workers and bad behavior with reverse time jump+}s
Author: Kinsey Moore
2025-03-06T20:32:53.773Z
changed the description
Author: Chris Johns
2025-03-07T00:28:05.378Z
approved this merge request
19 - bsd/ntp: Fix inifinite loop and crash¶
Id |
19 |
State |
merged |
Merged by |
Chris Johns |
Merged at |
2025-02-25T22:22:19.843Z |
Assignee(s) |
Kinsey Moore |
Created |
2025-02-25T16:03:53.357Z |
Updated |
2025-02-25T22:22:20.910Z |
Milestone |
6.2 |
Labels |
libbsd, pkg::network-services |
Link |
https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/19 |
Commit |
Summary¶
This is the backport MR for 6 branch for the NTP hang and crash fixes.
Closes #11
Author: Kinsey Moore
2025-02-25T16:03:53.556Z
assigned to @opticron
Author: Kinsey Moore
2025-02-25T16:35:04.782Z
changed title from bsd/ntp: {-Remove loop that can hang indefinitely-} to bsd/ntp: {+Fix inifinite loop and crash+}
Author: Chris Johns
2025-02-25T22:22:14.665Z
approved this merge request
17 - gitlab: Add link to CI¶
Id |
17 |
State |
merged |
Merged by |
Kinsey Moore |
Merged at |
2025-02-14T16:33:57.210Z |
Assignee(s) |
Amar Takhar |
Created |
2025-02-14T10:36:00.719Z |
Updated |
2025-02-14T16:33:58.474Z |
Milestone |
6.2 |
Labels |
ci |
Link |
https://gitlab.rtems.org/rtems/pkg/rtems-net-services/-/merge_requests/17 |
Commit |
Summary¶
gitlab: Add link to CI
This runs only the commit message and merge request checker.
Required so we can have ‘all pipelines must pass’ enabled due to a bug in GitLab.
Closes #6
Author: Amar Takhar
2025-02-14T10:36:00.918Z
assigned to @amar
Author: Kinsey Moore
2025-02-14T16:33:11.562Z
approved this merge request
Author: Kinsey Moore
2025-02-14T16:33:20.010Z
added 2 commits
d3768be8 - 1 commit from branch
rtems/pkg:66aff71f7 - gitlab: Add link to CI